Rewrite waitable atomics #9117

Nekotekina · 2020-10-23T17:24:35Z

Relatively big change to waitable atomics.

Don't return prematurely if condition is not met (does not affect ones with set timeout).
Use one semaphore per thread. This seems to improve efficiency in some scenarious for little sacrifice.

dio-gh · 2020-10-23T21:13:42Z

I was reached out to by friends on Discord, that you wanted this PR tested in relation to #8363.

I tested the latest PR build against the latest master build, and the issue persists:

On the left half of the frametime graph the game window was focused, on the right half the game window was unfocused. This is the same as on master.

Please mention the issue through Github next time instead, if you want it tested by those affected.

Nekotekina · 2020-10-23T21:19:07Z

Ahh that's unfortunate, but thank you for testing. I have other ideas in mind.

Nekotekina · 2020-10-24T02:19:17Z

Added new Win8+ API path which may dramatically change performance for everyone.
@dio-gh can be worth retesting.

dio-gh · 2020-10-24T03:27:46Z

Checked with the latest commit, the game (Demon's Souls) hangs on loading now. I also didn't notice an improvement sadly, but I couldn't check properly due to said hang. Gonna go sleep now.

RPCS3.log.zip

Edit: uploaded a new log, cause I originally had logging off.

Nekotekina · 2020-10-24T09:07:32Z

Last version seems working!

Use individual semaphore for each thread. Unfortunately, limit max thread waiting for single address (60). If limit is reached, use busy waiting.

Try non-blocking wake up function first.

Using raw_notify() everywhere was overkill.

Some of them are available only since Windows 8.

dio-gh · 2020-10-24T15:15:29Z

Color me impressed, the latest commit resolves most of #8363!

Demon's Souls is now working better than ever on my system.

A curious case to look at would be F1 Race Stars though. The game suffers massively from scheduling issues, it used to be that it'd run seamlessly unfocused, and lag then hang catastrophically when focused. That situation has improved with this, but I noticed that it's also having issues unfocused now. Whether this is due to the PR's changes, or the past months' master changes, I'm yet to test. Gonna go do that now.

Update: Seems like it's the latter, so this PR is a net improvement. 🎉 I can open a separate ticket for F1 Race Stars if preferred, since that's definitely an odd one out game.

Update 2: Tested another game called Dead Nation. There still seems to be a discrepancy between focused and unfocused unfortunately, but it's a lot milder now. I also asked for a retest in the original issue ticket, and a user already reported that they're still having issues; therefore, I'll keep the ticket open. Thanks for the fixes though, this is already a major step forward.

Win7 will remain using old API (keyed events).

legend800 · 2020-11-01T21:29:07Z

This broke SW Force Unleashed 2:
#9199

* Use atomic waitables instead instead of global thread wait as often as possible. * Add ::is_stopped() and and ::is_paued() which can be used in atomic loops and with atomic wait. (constexpr cpu flags test functions) * Fix notification bug of sys_spu_thread_group_exit/terminate. (old bug, enhanced by RPCS3#9117) * Function time statistics at Emu.Stop() restored. (instead of current "X syscall failed with 0x00000000 : 0") * Remove cpu_flag::dbg_global_stop, use cpu_flag::exit instead. (essentially a duplicated flag)

* Use atomic waitables instead instead of global thread wait as often as possible. * Add ::is_stopped() and and ::is_paued() which can be used in atomic loops and with atomic wait. (constexpr cpu flags test functions) * Fix notification bug of sys_spu_thread_group_exit/terminate. (old bug, enhanced by RPCS3#9117) * Function time statistics at Emu.Stop() restored. (instead of current "X syscall failed with 0x00000000 : 0") * Remove cpu_flag::dbg_global_stop, use cpu_flag::exit instead. (essentially a duplicated flag) * Added some thread_ctrl::wait_on to fix emulation stopping.

* Use atomic waitables instead instead of global thread wait as often as possible. * Add ::is_stopped() and and ::is_paued() which can be used in atomic loops and with atomic wait. (constexpr cpu flags test functions) * Fix notification bug of sys_spu_thread_group_exit/terminate. (old bug, enhanced by #9117) * Function time statistics at Emu.Stop() restored. (instead of current "X syscall failed with 0x00000000 : 0")

Nekotekina force-pushed the fixup branch 4 times, most recently from 0b3f604 to 9cd2d50 Compare October 23, 2020 20:25

Nekotekina force-pushed the fixup branch 4 times, most recently from ab22024 to 265f12c Compare October 24, 2020 01:57

Nekotekina force-pushed the fixup branch 2 times, most recently from 5fcf90f to c389fed Compare October 24, 2020 02:53

Nekotekina force-pushed the fixup branch from c389fed to c4b816c Compare October 24, 2020 09:03

Nekotekina added 7 commits October 24, 2020 14:16

Improve raw_notify a bit

10caa29

atomic.cpp: integrate callback check in ptr_cmp function

d48d677

atomic.cpp: rewrite internals (again)

8628fc4

Use individual semaphore for each thread. Unfortunately, limit max thread waiting for single address (60). If limit is reached, use busy waiting.

atomic.cpp: experimental optimization (Win7+)

c479d43

Try non-blocking wake up function first.

SPU: use normal notify() thread function

2b52b4a

Using raw_notify() everywhere was overkill.

Fix UTF-8 strings in perf_meter files

89d9813

Add imports for some undocumented NTDLL functions

97ae5ab

Some of them are available only since Windows 8.

Nekotekina force-pushed the fixup branch 6 times, most recently from 5f6329d to 8db8125 Compare October 24, 2020 14:28

dio-gh mentioned this pull request Oct 24, 2020

Games running way better with their windows' unfocused #8363

Closed

atomic.cpp: use new thread alerting API (Win8+)

7db77a5

Win7 will remain using old API (keyed events).

Nekotekina force-pushed the fixup branch from 8db8125 to 7db77a5 Compare October 24, 2020 16:06

Nekotekina merged commit 7db77a5 into RPCS3:master Oct 24, 2020

Asinin3 mentioned this pull request Oct 29, 2020

LEGO Harry Potter: Years 1-4 [BLES00720] Performance Regression #7133

Closed

legend800 mentioned this pull request Nov 1, 2020

Regression: Star Wars: The Force Unleashed II [NPUB30695], game hangs in menus now (#9117) #9199

Closed

elad335 mentioned this pull request Nov 5, 2020

Refactoring, bugfixes and fix emulation stopping #9208

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite waitable atomics #9117

Rewrite waitable atomics #9117

Nekotekina commented Oct 23, 2020

dio-gh commented Oct 23, 2020 •

edited

Nekotekina commented Oct 23, 2020 •

edited

Nekotekina commented Oct 24, 2020

dio-gh commented Oct 24, 2020 •

edited

Nekotekina commented Oct 24, 2020

dio-gh commented Oct 24, 2020 •

edited

legend800 commented Nov 1, 2020

Rewrite waitable atomics #9117

Rewrite waitable atomics #9117

Conversation

Nekotekina commented Oct 23, 2020

dio-gh commented Oct 23, 2020 • edited

Nekotekina commented Oct 23, 2020 • edited

Nekotekina commented Oct 24, 2020

dio-gh commented Oct 24, 2020 • edited

Nekotekina commented Oct 24, 2020

dio-gh commented Oct 24, 2020 • edited

legend800 commented Nov 1, 2020

dio-gh commented Oct 23, 2020 •

edited

Nekotekina commented Oct 23, 2020 •

edited

dio-gh commented Oct 24, 2020 •

edited

dio-gh commented Oct 24, 2020 •

edited