Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel explorer: Make it single-instance tool #9570

Merged
merged 3 commits into from
Jan 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions rpcs3/rpcs3qt/kernel_explorer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <QVBoxLayout>
#include <QPushButton>
#include <QHeaderView>
#include <QTreeWidget>
#include <QTreeWidgetItem>

#include "Emu/IdManager.h"
Expand Down Expand Up @@ -148,7 +149,9 @@ static QTreeWidgetItem* add_solid_node(QTreeWidget* tree, QTreeWidgetItem *paren
return node;
}

kernel_explorer::kernel_explorer(QWidget* parent) : QDialog(parent)
kernel_explorer::kernel_explorer(QWidget* parent, std::function<void()> on_destroy)
: QDialog(parent)
, m_on_destroy(on_destroy)
{
setWindowTitle(tr("Kernel Explorer"));
setObjectName("kernel_explorer");
Expand All @@ -167,11 +170,10 @@ kernel_explorer::kernel_explorer(QWidget* parent) : QDialog(parent)
m_tree->header()->close();

// Merge and display everything
vbox_panel->addSpacing(10);
vbox_panel->addSpacing(8);
vbox_panel->addLayout(hbox_buttons);
vbox_panel->addSpacing(10);
vbox_panel->addSpacing(8);
vbox_panel->addWidget(m_tree);
vbox_panel->addSpacing(10);
setLayout(vbox_panel);

// Events
Expand All @@ -180,6 +182,11 @@ kernel_explorer::kernel_explorer(QWidget* parent) : QDialog(parent)
Update();
}

kernel_explorer::~kernel_explorer()
{
m_on_destroy();
}

void kernel_explorer::Update()
{
const auto dct = g_fxo->get<lv2_memory_container>();
Expand Down
7 changes: 5 additions & 2 deletions rpcs3/rpcs3qt/kernel_explorer.h
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
#pragma once

#include <QDialog>
#include <QTreeWidget>

#include "util/types.hpp"

class QTreeWidget;

class kernel_explorer : public QDialog
{
Q_OBJECT
Expand All @@ -25,10 +26,12 @@ class kernel_explorer : public QDialog
};

public:
kernel_explorer(QWidget* parent);
kernel_explorer(QWidget* parent, std::function<void()> on_destroy);
~kernel_explorer();

private:
QTreeWidget* m_tree;
std::function<void()> m_on_destroy;

private Q_SLOTS:
void Update();
Expand Down
17 changes: 15 additions & 2 deletions rpcs3/rpcs3qt/main_window.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,12 @@ void main_window::OnEmuStop()
{
m_game_list_frame->Refresh();
}

// Close kernel explorer if running
if (m_kernel_explorer)
{
m_kernel_explorer->close();
}
}

void main_window::OnEmuReady()
Expand Down Expand Up @@ -1759,8 +1765,15 @@ void main_window::CreateConnects()

connect(ui->toolskernel_explorerAct, &QAction::triggered, [this]
{
kernel_explorer* kernelExplorer = new kernel_explorer(this);
kernelExplorer->show();
if (!m_kernel_explorer)
{
m_kernel_explorer = new kernel_explorer(this, [this]()
{
m_kernel_explorer = nullptr;
elad335 marked this conversation as resolved.
Show resolved Hide resolved
});
}

m_kernel_explorer->show();
});

connect(ui->toolsmemory_viewerAct, &QAction::triggered, [this]
Expand Down
2 changes: 2 additions & 0 deletions rpcs3/rpcs3qt/main_window.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class game_list_frame;
class gui_settings;
class emu_settings;
class persistent_settings;
class kernel_explorer;

struct gui_game_info;

Expand Down Expand Up @@ -164,6 +165,7 @@ private Q_SLOTS:
log_frame* m_log_frame = nullptr;
debugger_frame* m_debugger_frame = nullptr;
game_list_frame* m_game_list_frame = nullptr;
kernel_explorer* m_kernel_explorer = nullptr;
std::shared_ptr<gui_settings> m_gui_settings;
std::shared_ptr<emu_settings> m_emu_settings;
std::shared_ptr<persistent_settings> m_persistent_settings;
Expand Down