-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel explorer: Make it single-instance tool #9570
Conversation
I don't wanna be an ass. But this PR is really really bad.... :) |
Okay, is it the code or the purpose of the pr? |
Mostly the code. But I don't really understand what you're trying to accomplish anyway |
aa4c6f7
to
ddaf333
Compare
Cleaned the code a bit, added some reasoning in description. |
d141fd3
to
99bc9f9
Compare
rpcs3/rpcs3qt/main_window.cpp
Outdated
@@ -1971,6 +1984,7 @@ void main_window::CreateDockWindows() | |||
m_debugger_frame->setObjectName("debugger"); | |||
m_log_frame = new log_frame(m_gui_settings, m_mw); | |||
m_log_frame->setObjectName("logger"); | |||
m_kernel_explorer = new kernel_explorer(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole idea of having a persistent window is wrong.
A: there is no need for it to be created on boot
B: 99% of the users won't need it
C: it will always show up as a hidden window if you investigate your open windows
The correct way to do it is to make it non-modal and to use a singleton approach as seen in GalCiv's code (e.g. the skylanders dialog).
This also removes the need of a convoluted signal slot mechanic (which you overcomplicated by a lot, since there are already native signals for this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about now?
604c596
to
b3feaa9
Compare
9d7e9fe
to
9c0e602
Compare
Enhancements