-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging from upper right panel into main canvas leads to strange behavior #10
Comments
Make preview non-draggable? Absolutely not! :) This is the #1 way to get the token easily into MapTool. It's meant to drag the finished token either to MapTool or a file location (or into e-mail or other application). I suppose we could prevent dragfrom preview into main canvas but othewise all DnD events are purposely coded. (Also, this is how TokenTool 1.x worked as well) |
Ctrl-C and Ctrl-V doesn't work? I understand the ease of DnD, but it shouldn't be dragged onto the main canvas, I think. But I am not really using token tool, to be honest, so listen to your main users instead, whether this is a problem or an artifact found by an inexperienced tester. |
Using keystrokes requires the ability to "select" something, or just assume that the Preview window is always selected... I think disallowing the drag into the main window from the preview window makes the most sense. And it should be pretty easy to detect the source of the drop as 'self'. |
Granted, dragging the preview to the main canvas just replaces the existing portrait to be used. This could be used for some sort of "effect". I have users who already used TokenTool to create new "overlays" to use within TT so there may be use cases for this. Remember, just because one person doesn't use a tool a certain way doesn't mean it should be limited for others. #optionsForAll! :) |
By all means, do as you please here. I just fumbled around to see how you use JFX. And then I found the combo 1. drop preview on main. 2. resize token. That leads to reverse zooming into and out-of by the preview and main canvas. This is an "effect" of sorts and looks like a caleidoscope. Surely not intentional though. But that's what "playing around with it" leads to. At least when I'm in control :-) |
As long as the app doesn't crash, I suppose we can leave it. It might react strangely but, as Jamz says, I can see people quirks like these and taking advantage of them; as long as nothing breaks, it's probably fine. :) |
FYI: I'm 99% sure this was the behavior in TokenTool 1.x and it didn't cause anyone any issues. :) |
That's true. You could drag from the preview down into the composition area and add ring after ring after ring until the little portrait was too small to see anymore. |
* #7: Add PDF Extraction Initial check-in of PDF Extraction code, working beta 1! Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction Adjustments for better window resizing. Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction Updated travis. Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * Cleanup * Ignore eclipse .settings * Updated PDFBox libs * Updated Gradle Wrapper to 4.7 Task-Url: JamzTheMan/MapTool#37 Signed-off-by: Jamz <Jamz@Nerps.net> * PDF Enhancements * Removed ImageGallery fxml/controller - unneeded complexity * Added PDF Window i18n title * Changed sentry.io logging to ERROR * Added caching of main PDF image render * Fixed auto resizing of main PDF image * Added drag/drop from PDF extract buttons Signed-off-by: Jamz <Jamz@Nerps.net> * #9: Pog filenames substitute %20 for spaces * Properly decode file names for saving to file * minor cleanup on other files Task-Url: http://github.com/JamzTheMan/TokenTool/issues/9 Signed-off-by: Jamz <Jamz@Nerps.net> * #10: Add arrow key nudges * Added 1 pixel nudge on arrow keys Task-Url: http://github.com/JamzTheMan/TokenTool/issues/10 Signed-off-by: Jamz <Jamz@Nerps.net> * #13: Allow user supplied image for background - WIP * Added button to supply background image * updated token preview clipping to use background image Task-Url: http://github.com/JamzTheMan/TokenTool/issues/13 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Updated Travis CI to install latest java via brew * Updated config to use environment variables from Travis config. Should be generic now for upstream repo Task-Url: JamzTheMan#12 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Updated Travis CI to install latest java via brew * Updated config to use environment variables from Travis config. Should be generic now for upstream repo * Updated Appveyor config * WIP - working on errors in travis... Task-Url: JamzTheMan#12 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Removed DLL from Inno Setup template * Add TokenTool.iss to .gitignore as this is built for every deploy * Moved Vendor to gradle.properties so it's static for the repo Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Version now grabbed from Tag. If no tag, version = SNAPSHOT+Commit Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Added missing platform x64 config for appveyor... Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Changed gradle deploy to run only 'before_deploy' (was always running) Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * Update .appveyor.yml * #8: Bug in pdf-extract-feature branch * Can now drop PDF files to open them * ImageIO lib updated, no longer throws error Task-Url: http://github.com/JamzTheMan/TokenTool/issues/8 Signed-off-by: Jamz <Jamz@Nerps.net> * #14: Add a keyboard shortcut to take a screen capture. * Added shortcut to Capture Screen menu option per request * Updated and added other shortcuts to menu options Task-Url: http://github.com/JamzTheMan/TokenTool/issues/14 Signed-off-by: Jamz <Jamz@Nerps.net> * Layer support WIP * #13: Allow user supplied image for background * Added drag and drop areas to denote if image is portrait or background * Added layer selection menu button to drive scroll/rotate events WIP * Changed Preference saving to handle ImageView's a little easier * Added system.exit to kill any lingering threads from PDF extractions * Updated Paste/Screen Capture/PDF Extract to put image on currently selected layer * All child windows now remember position and size * Swipe touch event should move 1 page at a time now * New menu option to Reset Settings to factory defaults Task-Url: http://github.com/JamzTheMan/TokenTool/issues/13 Signed-off-by: Jamz <Jamz@Nerps.net> * Logging and Build changes * Sentry now logs OS * Sentry now configures as Development on non tagged commits. * Sentry bumped to 1.7.5 * gradle.properties now hole vendor and sentry DSN for more flexibility * Adding a tag now configures Sentry to Production mode, sets Release version and kicks off Deployment in CI Signed-off-by: Jamz <Jamz@Nerps.net> * #13: Allow user supplied image for background * Help -> Reset menu now has confirmation/cancel dialog * FXML/UI tweaked to better handle ImageViews to remain centered on stage resize (background and portrait) and refactored code to simpler binding Task-Url: http://github.com/JamzTheMan/TokenTool/issues/13 Signed-off-by: Jamz <Jamz@Nerps.net> * #13: Allow user supplied image for background * Right click on pdf extract sets background vs portrait * Sentry.io only logs in Production mode now * WIP: Portrait naming Task-Url: http://github.com/JamzTheMan/TokenTool/issues/13 Signed-off-by: Jamz <Jamz@Nerps.net> * #17: Imported PNG overlays coming in at 100x100 * Fixed png thumbs being imported at default thumb size of 100 Task-Url: http://github.com/JamzTheMan/TokenTool/issues/17 Signed-off-by: Jamz <Jamz@Nerps.net> * #19: Add ESC key to cancel Screen Capture * Added esc key event capture * Added highlighting to drag icons Task-Url: http://github.com/JamzTheMan/TokenTool/issues/19 Signed-off-by: Jamz <Jamz@Nerps.net> * #13: Allow user supplied image for background * Final tweaks on new save options, can now save portrait with backgound options on drag and drop along with normal token image Task-Url: http://github.com/JamzTheMan/TokenTool/issues/13 Signed-off-by: Jamz <Jamz@Nerps.net> * New Overlays * A few new overlays added * AppSetup will only install new overlays since last version installed * TODO: i18n properties still need to be updated... Task-Url: http://github.com/JamzTheMan/TokenTool/issues/13 Signed-off-by: Jamz <Jamz@Nerps.net> * Misc * Added some card type overlay bases * Added label under overlay name above overlay tree to dispaly native overlay dimensions, eg 512 x 512 * Updated i18n files with new externalized strings Task-Url: http://github.com/JamzTheMan/TokenTool/issues/13 Signed-off-by: Jamz <Jamz@Nerps.net> * Misc * i18n'd Layer Menu button Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Fixed bug with brew per Homebrew/homebrew-cask#49716 Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction * PDF image extraction now on it's own service thread * Added progress indicator for long image extractions Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #7: Add PDF Extraction * Spotless... * Tagged! Task-Url: http://github.com/JamzTheMan/TokenTool/issues/7 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * getting the appveyor key to work? Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * Another try at env vars Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * #12: Update CI config and install to Java 10 * YAT Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * Still testing AppVeyor... * YAT WTF Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net> * 12: Update CI config and install to Java 10 Task-Url: http://github.com/JamzTheMan/TokenTool/issues/12 Signed-off-by: Jamz <Jamz@Nerps.net>
What happens looks consistent to a developer but a layman would consider this sureal.
I propose to make the preview non-draggable. I don't think this is intentional. In fact, when a token is copied from the main canvas, this preview is actually what is dropped. This drop on the main canvas may be intentional with copy and paste, but the drop from the preview is mostly accidental.
At least a one-step undo would be great here too.
The text was updated successfully, but these errors were encountered: