Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditTokenDialog: Change GUI-Editor to Intellij GUI designer #3785

Merged
merged 18 commits into from
Dec 27, 2022

Conversation

thelsing
Copy link
Collaborator

@thelsing thelsing commented Dec 22, 2022

Part of #3792

Changes

  • Add support to any JComponent as View of AbeiilePanel with translation, control replacement etc.
  • Convert EditTokenDialog to IntelliJ GUI-Editor

This change is Reviewable

@thelsing thelsing marked this pull request as draft December 22, 2022 01:29
@thelsing thelsing marked this pull request as ready for review December 27, 2022 14:53
@thelsing
Copy link
Collaborator Author

Not sure what the problem of the build is. It ran fine in my repo: https://github.com/thelsing/maptool/actions/runs/3787253474

@thelsing thelsing changed the title Change GUI-Editor to Intellij GUI designer. EditTokenDialog: Change GUI-Editor to Intellij GUI designer Dec 27, 2022
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 7 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @thelsing)

@Phergus Phergus merged commit 4375a75 into RPTools:develop Dec 27, 2022
@thelsing thelsing deleted the develop branch December 27, 2022 16:37
@cwisniew cwisniew added the feature Adding functionality that adds value label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants