-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all abaille forms to intellij gui editor #3799
Conversation
Is this something that should perhaps go into a separate branch with separate test builds? I'm just thinking of how big a snafu it would be for a glitch to be part of a normal release...? |
Who will test it in a different branch? Nobody will. In the develop branch at least developers will test the stuff they need during development. In a separate branch even that won't happen. IMO separate branches only make sense when we plan a release in the next few days and want to safely store the changes. But even than it's better to just leave the PR open. That way we know faster when merging breaks. |
Also #3792 lists all the dialogs. So we can check them one by one before doing a release. |
Just a small marathon, eh? 😆 I'm excited for these changes. Unless someone beats me to it, I'll take a look at them tomorrow (it's quite late here).
I don't see that as necessary. We can test these changes before merging, after merging, and then even if a release has a critical issue we can always patch or revert as makes sense. Kind of part of the release cycle anyways tbh 😅 |
…dPanel to ColorWell)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 94 of 158 files at r1, 67 of 67 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @thelsing)
Identify the Bug or Feature request
resolves #3792
Description of the Change
I converted all forms in a little marathon. Having used it quite a lot, I can now say that I like the intellij UI editor.
I removed I18Panel and the recursive translation of component texts as they are all translated automatically in the
code generated from the GUI editor. Only ComboBox item can't be translated this way. I change the two instances that depended on this to manual translation. All other ComboBox items were already translated this way.
I also moved restructured the packages for the UI because we now have a *View.frm and a *View.java for each dialog/panel. This way they are grouped together.
I also fixed two bugs with AdjustGridDialog and AdjustBoardDialog introduced by the Eventbus change.
Possible Drawbacks
Layout could be weird in some cases. I may have overlooked some translation in a Combobox.
Release Notes
This change is