Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pathfinding based on token layer, not selected layer #3868

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Mar 16, 2023

Identify the Bug or Feature request

Addresses #3754

Description of the Change

When deciding whether a Token should pathfind, we now look at the Token itself to determine its layer, rather than depending on the currently selected layer. Tokens will pathfind, while stamps will not.

Possible Drawbacks

Should be none.

Documentation Notes

N/A, bugfix

Release Notes

  • Fix a bug where tokens on the Token layer would not pathfind on a GM client if the token was moved by another client and the GM had a different layer selected.

This change is Reviewable

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)

@Phergus
Copy link
Contributor

Phergus commented Mar 16, 2023

@kwvanderlinde Spotless failed.

@kwvanderlinde kwvanderlinde force-pushed the bugfix/3754-pathfinding-based-on-token-layer branch from 9cf97db to 7552de9 Compare March 16, 2023 16:53
@kwvanderlinde
Copy link
Collaborator Author

Fixed that. Suddenly it want a blanks line 🤷

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)

@Phergus Phergus merged commit 98e0766 into RPTools:develop Mar 16, 2023
@kwvanderlinde kwvanderlinde deleted the bugfix/3754-pathfinding-based-on-token-layer branch March 16, 2023 23:50
@cwisniew cwisniew added the bug label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants