Uses lower-case extensions for Aah preview image #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new ImageIcon( | ||
| ThemeSupport.class.getResource(IMAGE_PATH + themeDetails.imagePath), | ||
| themeDetails.name); | ||
| new ImageIcon(ThemeSupport.class.getResource(imageLocation), themeDetails.name); |
There was a problem hiding this comment.
We can use imageURL here as well for a bit more clarity.
There was a problem hiding this comment.
Thanks for pointing this out, I actually wanted to do that!
kwvanderlinde
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #3892
Description of the Change
The preview files for Aah theme had a
PNGfilename extension, but were referred aspngin the code; this change renames the filename name extensions topngfor consistency with all the other images already in the package.The change also adds some logs around the retrieval of the image, and the usage of an empty ImageIcon in case the preview can't be loaded.
Possible Drawbacks
The performance loss caused by the logs should be negligible, as this happens only when retrieving the theme.
The usage of an empty ImageIcon prevents a traceback to reach the customer, but could hide the problem (i.e. the fact that the names of the preview files are wrong). This risk is mitigated however by the fact that the condition is correctly logged in the files.
Documentation Notes
Note that the problem doesn't manifest itself when developing on Windows, because the resource is accessed via a file system path, which are case-insensitive under Windows.
Release Notes
This change is