Tweak the toolbar separators #3974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All separators in the toolbar are now created via a helper method that builds a separator with symmetric padding. This is done in favour of sandwiching a separator between struts and allows the separator itself to decide how to pad itself. If orientation support is added again in the future, the separator will provide a way to pad itself appropriately with needing separator struts for vertical and horizontal orientations. As a result, the separator between the tools and the option panel now has symmetric padding instead of being right up against the VBL tool button. A separator was also added in the *BL option panel, between the shape tools and the mode selector. This distinguishes the two now that we have a flatter and less colourful set of icons. The toolbar is no longer floatable. This happened to be the case already since 1.12 due to FlatLaf defaulting to non-floatable toolbars. By making this explict, we don't have to keep around the logic needed for floating and orientation changes, nor will this be a theme-dependent bit of functionality. Floating can always be added again in the future if it's deemed desirable, along with better orientation support.
cwisniew
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Implements #3893
Description of the Change
All separators in the toolbar are now created via a helper method that builds a separator with symmetric padding. This is done in favour of sandwiching a separator between struts and allows the separator itself to decide how to pad itself. If orientation support is added again in the future, the separator will provide a way to pad itself appropriately with needing separator struts for vertical and horizontal orientations.
As a result, the separator between the tools and the option panel now has symmetric padding instead of being right up against the VBL tool button. A separator was also added in the *BL option panel, between the shape tools and the mode selector. This distinguishes the two now that we have a flatter and less colourful set of icons.
A bit of padding was adding to both ends of the panel so that the contents aren't pushed uncomfortably close to the edge of the window.
The toolbar is no longer floatable. This happened to be the case already since 1.12 due to FlatLaf defaulting to non-floatable toolbars. By making this explict, we don't have to keep around the logic needed for floating and orientation changes, nor will this be a theme-dependent bit of functionality. Floating can always be added again in the future if it's deemed desirable, along with better orientation support.
Possible Drawbacks
Some might like floating. But that's already disabled in 1.12 and in the 1.13 betas for all themes other than Aah.
Documentation Notes
N/A
Release Notes
This change is