Invalid sight is breaking vision #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
#4037
Description of the Change
There are some situations where a token's sight is not actually a sight defined in the campaign. This is mostly handled by
nullchecks, but this was missed when calculating illumination keys. In a similar vein, not all tokens have sight, and this is handled in much the same way as an undefined sight type.This PR fixes the one place where we don't currently check the validity of the sight type, and where we also don't check if the token has sight: building the illumination key.
Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is