Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature devmode #4311

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Feature devmode #4311

merged 2 commits into from
Sep 30, 2023

Conversation

thelsing
Copy link
Collaborator

@thelsing thelsing commented Sep 30, 2023

Identify the Bug or Feature request

Fixes #4310

Description of the Change

We now no longer check if the version name contains SNAPSHOT or something but tell MT with a -DRUN_IN_IDE=true switch if it runs in a IDE. This way installed versions never think themselves as "in development."

Possible Drawbacks

Unless there is a reason for installed snapshots to know that they are "in development": none.


This change is Reviewable

@cwisniew cwisniew added the bug label Sep 30, 2023
@cwisniew cwisniew added this pull request to the merge queue Sep 30, 2023
Merged via the queue into RPTools:develop with commit 4f87ecc Sep 30, 2023
4 checks passed
@thelsing thelsing deleted the feature-devmode branch November 17, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: With the new "don't save in install dir" snapshots build can't save in user home dir
2 participants