Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update topology toolbar tooltip to include movement blocking #4773

Merged
merged 4 commits into from
May 14, 2024
Merged

Update topology toolbar tooltip to include movement blocking #4773

merged 4 commits into from
May 14, 2024

Commits on May 7, 2024

  1. Update topology toolbar tooltip to include movement blocking

    @kwvanderlinde
    kwvanderlinde committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8a66861 View commit details
    Browse the repository at this point in the history

  2. Fix several tools to update the coordinate status bar 

    All topology tools needed this fix, as did the oval drawing tool. Each one of these failed to call `super.mouseMoved()`
in their respective overrides but now do so at the start of the method.

The board and grid adjust tools were similar, but did not need their overrides at all.
    @kwvanderlinde
    kwvanderlinde committed May 7, 2024
    Configuration menu
    Copy the full SHA
    80ff44a View commit details
    Browse the repository at this point in the history

  3. Change Pointer, Stamp and Line tool to call super at start of method 

    This ensures the mouse coordinates are saved and the coordinate status bar is updated, regardless of whatever else
happens in these methods.
    @kwvanderlinde
    kwvanderlinde committed May 7, 2024
    Configuration menu
    Copy the full SHA
    28b4548 View commit details
    Browse the repository at this point in the history

  4. Clean up DrawnLabel 

    This is a legacy label implementation, referenced nowhere except during serialization. We have to keep it around because
campaigns may have them serialized. However the corresponding tool `DrawnTextTool` is unused and has been removed, and
some parts of `DrawnLabel` could be removed as well.
    @kwvanderlinde
    kwvanderlinde committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0c1e2cd View commit details
    Browse the repository at this point in the history