Add check and warning for a space presence in the base path #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shellcheck is complaining about a few word-splitting issues, do you want me to fix them here too or should I create another PR to keep things clean? Also, I'm happy to make changes to wording and such in the README and in the warning message. |
XECDesign
force-pushed
the
base_path_fix
branch
from
f951861
to
2f161a1
Compare
|
Many thanks |
Generally separate PRs for separate issues are better. |
|
My thoughts exactly, I'll do that then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening of #417 from a different upstream repo to keep things cleaner.
This PR closes #75 with a Upstream issue reason. For now, debootstrap doesn't support spaces in path, so we just check for the presence of a space character in the base path, warn the user and exit early before trying anything.