Turning on the debug build now also disables optimizations for GCC. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR. I always debugged with -O2 and it was suitable for my needs. I won't merge your PR because I don't want to have general changes in the compiler-specific files. I added it to config_defines.mk where the -g flag is added to CFLAGS when DEBUG is set to true. The inlines are also removed from the two functions in calculator.c |
TomTheBear
added a commit
that referenced
this pull request
Aug 31, 2016
…n relation to PR #52 which does the changes in other files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using -O0 is a real pita when trying to debug things with gdb.
Unfortunately this step also requires uninlining two functions, which are optimized away in the release build, but cause linker problems when left in.