Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated nvim-treesitter functionality #170

Closed
wants to merge 1 commit into from

Conversation

amaanq
Copy link

@amaanq amaanq commented Jul 5, 2023

ts_utils and modules are deprecated in the new main branch of nvim-treesitter, and master will likely be deprecated once 0.10 is out (though not removed for a while for compatibility reasons). It'd be better to adjust for that sooner rather than later, as main currently offers many benefits over master but the module usage here will prevent users from using that. Though, disabling by filetype will be unusable (until you implement something similar..) and it is a slight breaking change for users

@RRethy RRethy self-requested a review July 23, 2023 12:38
Copy link
Owner

@RRethy RRethy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work, require('illuminate.providers.treesitter').is_ready() will always return false. I'll look into how to detect if ts is attached for the buffer.

@RRethy
Copy link
Owner

RRethy commented Aug 1, 2023

ts_utils and modules are deprecated in the new main branch of nvim-treesitter, and master will likely be deprecated once 0.10 is out

Is there an announcement about this? A migration guide?

@RRethy
Copy link
Owner

RRethy commented Aug 1, 2023

Though, disabling by filetype will be unusable (until you implement something similar..)

That exists in vim-illuminate already fwiw

@RRethy
Copy link
Owner

RRethy commented Sep 12, 2023

Closing because this is a broken PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants