Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TwitterBridge] Remember cookies during redirects #1226

Closed
wants to merge 1 commit into from
Closed

[TwitterBridge] Remember cookies during redirects #1226

wants to merge 1 commit into from

Conversation

Roliga
Copy link
Contributor

@Roliga Roliga commented Jul 25, 2019

The first request to twitter now sets a session cookie then redirects to
the same page, so without this cookie a redirect loop happens.

This change tells curl to remember cookies when redirects happen.

References #1225.

@Roliga
[TwitterBridge] Remember cookies during redirects
4966f2a 
The first request to twitter now sets a session cookie then redirects to
the same page, so without this cookie a redirect loop happens.

This change tells curl to remember cookies when redirects happen.

References RSS-Bridge#1225.
@Pofilo Pofilo mentioned this pull request Jul 25, 2019
Closed
@triatic
Copy link
Contributor

triatic commented Jul 25, 2019

To maintain compatibility with file_get_contents() in getContents(), I believe the correct way to fix this is to fetch the cookies in TwitterBridge and then pass them to getSimpleHTMLDOM() via collectData() in TwitterBridge.

@triatic
Copy link
Contributor

triatic commented Jul 25, 2019

FB2Bridge has a function to fetch cookies, getCookies(), which could be used.

@triatic
Copy link
Contributor

triatic commented Jul 26, 2019

I've made PR #1232 which integrates better within the existing framework.

@triatic triatic mentioned this pull request Jul 26, 2019
Merged
@Roliga Roliga closed this Jul 26, 2019
@illwieckz illwieckz mentioned this pull request Jul 28, 2019
Closed
@triatic
Copy link
Contributor

triatic commented Jul 30, 2019 •
edited
Loading

Conditionally implementing suggestion by @Roliga to cure allow_url_fopen issues in #1245 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Roliga @triatic