[TwitterBridge] Get cookies before sending request #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twitter now requires cookies to be set before requesting a page. This will fetch the cookies and send them to `getSimpleHTMLDOM()`.
|
This may be the better approach yes, I didn't realize A slight downside with this is that as far as I can tell it doesn't take proxy settings into account, which could be problematic in some cases. Though I suppose if the FB2Bridge is already doing it this way maybe it's fine. |
|
Thanks for the fix ! |
|
@Roliga The function doesn't currently respect headers passed in (such as the cookie one just added) so I'll need to PR that. |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
* [TwitterBridge] Get cookies before sending request Twitter now requires cookies to be set before requesting a page. This will fetch the cookies and send them to `getSimpleHTMLDOM()`. * Formatting fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter now requires cookies to be set before requesting a page. This will fetch the cookies and send them to
getSimpleHTMLDOM().Fixes #1225 #1231
Supersedes PR #1226
Function to get cookies borrowed from @teromene / FB2Bridge