[ReutersBridge] Add New Bridge #1653

hollowleviathan · 2020-07-13T17:24:17Z

Adds bridge requested in #1618

csisoap · 2020-07-14T13:32:17Z

Bridge is working perfectly.
Thank you.
But it seem "Pictures" section isn't working. I got blank page on that section.

Query string: action=display&bridge=Reuters&feed=pictures&format=Html

somini · 2020-07-14T23:03:02Z

csisoap · 2020-07-17T05:24:54Z

It would be great if it can get the article from "Editor's Highlight" in the above picture. It seem they are different than the "story" type.

Spraynard · 2020-12-25T17:16:06Z

Are there any issues regarding merging this PR? I can help get everything ready for merging if the project needs it

hollowleviathan · 2020-12-26T12:38:59Z

The primary concern from the RSS-Bridge team seems to be checking if #1651 does anything this PR doesn't and incorporating it. Since that PR is a scrape of the UK reuters site, I'm daunted by figuring out how to understand what advantages, if any, it has over using the direct API.

I also notice there's a bug where this PR has some tag text gunk at the end of articles "for-phone-onlyfor-tablet-portrait-upfor-tablet-landscape-upfor-dekstop-upfor-wide-desktop-up"

Spraynard · 2020-12-26T20:32:22Z

Alright thank you for giving me an update! I'll see if there's anything that can be added

csisoap · 2020-12-27T10:28:28Z

The primary concern from the RSS-Bridge team seems to be checking if #1651 does anything this PR doesn't and incorporating it. Since that PR is a scrape of the UK reuters site, I'm daunted by figuring out how to understand what advantages, if any, it has over using the direct API.

I also notice there's a bug where this PR has some tag text gunk at the end of articles "for-phone-onlyfor-tablet-portrait-upfor-tablet-landscape-upfor-dekstop-upfor-wide-desktop-up"

Can i ask where you get that bug from?

I think the advantage of this using direct API is that you get all info of that article (id, timestamp, article's content,...).

hollowleviathan · 2020-12-27T12:00:45Z

Can i ask where you get that bug from?

Observation from using this PR myself.

I think the advantage of this using direct API is that you get all info of that article (id, timestamp, article's content,...).

Yes, I think using the direct API is superior and should get all of the news items that a scrape gets and more, but how do you prove that?

Spraynard · 2020-12-27T17:11:04Z

Yes, I think using the direct API is superior and should get all of the news items that a scrape gets and more, but how do you prove that?

From what I understand I don't think people are arguing to keep the scraping method, I just think people are wondering if there's any more information obtained from the scrape, (or even a different source of information) than what is being obtained in this bridge.

Just briefly looking while writing this comment, our bridge is pulling from https://reuters.com whereas #1651 bridge data is coming from https://uk.reuters.com. We might have to put a selector in our bridge to merge in uk.reuters data. Sorry I'm trying to remember what is actually happening and I was ignorant

Spraynard · 2020-12-28T04:56:47Z

This linked pull request to the reuters branch of @hollowleviathan's repo should combine the functionality between this PR and #1651.

Selecting US will present stories and link back to reuters.com, whereas selecting UK will link back to uk.reuters.com.

News Feed types now selectable through a list parameter JSON return is now being parsed correctly Stories being gathered in a stepwise process

…d more categories

[ReutersBridge] Add all article from 'Editor\'s Highlight' to the feed, more categories, author name, full article text.

Adding region selection to ReutersBridge

csisoap · 2021-01-05T03:35:15Z

The PR is now ready to be merged. It's just need to get merge with PR #1651.

Spraynard · 2021-01-10T08:17:10Z

@csisoap Sorry I am unsure what you mean by merge with the other PR. I looked at what #1651 was doing and saw that it was looking at stories from uk.reuters.com and so I added the region contexts. I think that we can merge this and have to ask #1651 to close their pull request 😔

csisoap · 2021-01-10T09:30:54Z

@csisoap Sorry I am unsure what you mean by merge with the other PR. I looked at what #1651 was doing and saw that it was looking at stories from uk.reuters.com and so I added the region contexts. I think that we can merge this and have to ask #1651 to close their pull request 😔

Yeah, my fault. Sorry about that, i'm terrible at English :(

About asking #1651 , i tried to ask him to check this PR but i haven't received any response.

Spraynard · 2021-01-10T18:12:25Z

You're fine :) English is a dumb language anyway.

Hmmm okay. Well I don't know who reviews these pull requests but since this one seems to be more robust and is working fine I think it can be merged. I don't know if #1651 is viable anymore

csisoap · 2021-01-11T03:40:07Z

@Spraynard it seem there only @em92 doing review for PRs right now.

em92

UK and US feeds look equal.
https://feed.eugenemolotov.ru/pr1653/?action=display&bridge=Reuters&context=United+States&feed_us=tech&format=Html
https://feed.eugenemolotov.ru/pr1653/?action=display&bridge=Reuters&context=United+States&feed_uk=tech&format=Html

Is that expected?

em92 · 2021-01-17T11:46:47Z

bridges/ReutersBridge.php

+		'United Kingdom' => array(
+			'feed_uk' => array(
+				'name' => 'News Feed',
+				'type' => 'list',
+				'title' => 'Feeds from Reuters U.K edition',
+				'values' => array(
+					'Tech' => 'tech',
+					'Wire' => 'wire',
+					'Business' => 'business',
+					'World' => 'world',
+					'Politics' => 'politics',
+					'Science' => 'science',
+					'Energy' => 'energy',
+					'Aerospace and Defense' => 'aerospace',
+					'Special Reports' => 'special-reports',
+					'Top News' => 'home/topnews',
+					'Markets' => 'markets',
+					'Sports' => 'sports',
+					'UK' => 'uk',
+					'Entertainment' => 'entertainment',
+					'Environment' => 'environment',
+					'Lifestyle' => 'lifestyle',
+				)
+			)
+		),
+		'United States' => array(
+			'feed_us' => array(
+				'name' => 'News Feed',
+				'type' => 'list',
+				'title' => 'Feeds from Reuters U.S/International edition',
+				'values' => array(
+					'Tech' => 'tech',
+					'Wire' => 'wire',
+					'Health' => 'health',
+					'Business' => 'business',
+					'World' => 'world',
+					'Politics' => 'politics',
+					'Science' => 'science',
+					'Lifestyle' => 'life',
+					'Energy' => 'energy',
+					'Aerospace and Defense' => 'aerospace',
+					'Special Reports' => 'special-reports',
+					'China' => 'china',
+					'Top News' => 'home/topnews',
+					'Markets' => 'markets',
+					'Sports' => 'sports',
+					'USA News' => 'us',
+				)
+			)


I suggest to extract common catogories to some array. Then use array_merge to add non-common ones.

Hi, i tried to split up common categories to some array and when i tried to merge, the compiler doesn't happy with me as const don't allow expression. Same happen with private. I don't know how to merge two array into one giant parameter as you saw in the code. There are spread operator which can use to merge but it's on PHP 7.4 which may failed some test for older version.

I just hope this bridge will soon to be merged.

csisoap · 2021-01-17T14:18:17Z

UK and US feeds look equal.
https://feed.eugenemolotov.ru/pr1653/?action=display&bridge=Reuters&context=United+States&feed_us=tech&format=Html
https://feed.eugenemolotov.ru/pr1653/?action=display&bridge=Reuters&context=United+States&feed_uk=tech&format=Html

Is that expected?

You have to change the context param to United Kingdom on the second link to see what different between two feeds. Sometimes they equal each other, but if you look into other feed like World, Top News, you'll see the order between is different.

- Health feed in the U.S context now using different feed. - Bridge now support using a unique feed ID instead of normal name. - Remove U.K context. - Add some new feeds.

em92 · 2021-01-22T05:09:37Z

Alphabetical order is required. Hard to find category, that user could be interested in.

@Spraynard and @hollowleviathan. There was a discussion about UK and US versions of reuters. Is it fine, that latest changes remove separated US and UK feeds?

csisoap · 2021-01-23T11:18:59Z

Hi @em92
The reason to remove U.K context was that Reuters merged several edition, includes U.K, into one global site so i personally think it would not necessary to use U.K context anymore.
I have added all feeds that specfic to U.K edition into U.S context.

You can find their statement here.

Sorting selection of news feed values

Spraynard · 2021-01-24T19:10:06Z

News feed items have been sorted with this pull request. Once we get that merged we should fit the sorted feed items criteria.

em92 · 2021-01-25T05:04:15Z

You can find their statement here.

Fair enough.

News feed items have been sorted with this pull request. Once we get that merged we should fit the sorted feed items criteria.

@hollowleviathan waiting for you to push mentioned PR.

csisoap · 2021-01-29T11:05:51Z

Pinging @hollowleviathan just in case he forgot.

Updating ReutersBridge

hollowleviathan · 2021-01-29T15:41:31Z

Sorry about the delay, merged now.

em92 · 2021-01-29T17:57:50Z

gj you all!

Spraynard · 2021-02-04T01:58:29Z

Amazing!!!!!

hollowleviathan changed the title ~~[ReutersBridge] Add New Bridge (#1618)~~ [ReutersBridge] Add New Bridge Jul 13, 2020

hollowleviathan force-pushed the reuters branch from 7ebe537 to ce6f42c Compare July 13, 2020 18:29

somini mentioned this pull request Jul 14, 2020

[ReutersUKBridge] Add new bridge #1651

Closed

hollowleviathan force-pushed the reuters branch 6 times, most recently from 581fbfc to 0e41636 Compare July 24, 2020 18:45

csisoap mentioned this pull request Sep 22, 2020

Bridge request for Reuters #1618

Closed

10 tasks

hollowleviathan force-pushed the reuters branch from b600c35 to d4a689d Compare October 8, 2020 19:17

hollowleviathan force-pushed the reuters branch from d4a689d to f959043 Compare October 20, 2020 20:06

hollowleviathan and others added 6 commits December 30, 2020 17:21

[Reuters] New bridge

f62ba35

Modifying ReutersBridge

42acf59

News Feed types now selectable through a list parameter JSON return is now being parsed correctly Stories being gathered in a stepwise process

[Reuters] Fix code style

69bca48

[ReutersBridge] Add Editor's Highlight to feed, add feed name, and ad…

29b51d5

…d more categories

[Reuters] Fix code style

8abc796

Modifying ReutersBridge (#5)

da901cc

[ReutersBridge] Add all article from 'Editor\'s Highlight' to the feed, more categories, author name, full article text.

hollowleviathan force-pushed the reuters branch from df9979d to da901cc Compare December 30, 2020 15:22

Adding region selection to ReutersBridge (#10)

fc81273

Adding region selection to ReutersBridge

em92 reviewed Jan 17, 2021

View reviewed changes

[ReutersBridge] New change (#11)

c499501

- Health feed in the U.S context now using different feed. - Bridge now support using a unique feed ID instead of normal name. - Remove U.K context. - Add some new feeds.

Updating ReutersBridge

f23653a

Sorting selection of news feed values

Merge pull request #12 from Spraynard/reuters

7df1a37

Updating ReutersBridge

em92 merged commit 43b7621 into RSS-Bridge:master Jan 29, 2021

hollowleviathan deleted the reuters branch February 3, 2021 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ReutersBridge] Add New Bridge #1653

[ReutersBridge] Add New Bridge #1653

hollowleviathan commented Jul 13, 2020 •

edited

csisoap commented Jul 14, 2020

somini commented Jul 14, 2020

csisoap commented Jul 17, 2020 •

edited

Spraynard commented Dec 25, 2020 •

edited

hollowleviathan commented Dec 26, 2020 •

edited

Spraynard commented Dec 26, 2020

csisoap commented Dec 27, 2020

hollowleviathan commented Dec 27, 2020

Spraynard commented Dec 27, 2020 •

edited

Spraynard commented Dec 28, 2020

csisoap commented Jan 5, 2021 •

edited

Spraynard commented Jan 10, 2021

csisoap commented Jan 10, 2021 •

edited

Spraynard commented Jan 10, 2021

csisoap commented Jan 11, 2021 •

edited

em92 left a comment

em92 Jan 17, 2021

csisoap Jan 19, 2021 •

edited

csisoap commented Jan 17, 2021 •

edited

em92 commented Jan 22, 2021

csisoap commented Jan 23, 2021 •

edited

Spraynard commented Jan 24, 2021

em92 commented Jan 25, 2021

csisoap commented Jan 29, 2021

hollowleviathan commented Jan 29, 2021

em92 commented Jan 29, 2021

Spraynard commented Feb 4, 2021

[ReutersBridge] Add New Bridge #1653

[ReutersBridge] Add New Bridge #1653

Conversation

hollowleviathan commented Jul 13, 2020 • edited

csisoap commented Jul 14, 2020

somini commented Jul 14, 2020

csisoap commented Jul 17, 2020 • edited

Spraynard commented Dec 25, 2020 • edited

hollowleviathan commented Dec 26, 2020 • edited

Spraynard commented Dec 26, 2020

csisoap commented Dec 27, 2020

hollowleviathan commented Dec 27, 2020

Spraynard commented Dec 27, 2020 • edited

Spraynard commented Dec 28, 2020

csisoap commented Jan 5, 2021 • edited

Spraynard commented Jan 10, 2021

csisoap commented Jan 10, 2021 • edited

Spraynard commented Jan 10, 2021

csisoap commented Jan 11, 2021 • edited

em92 left a comment

Choose a reason for hiding this comment

em92 Jan 17, 2021

Choose a reason for hiding this comment

csisoap Jan 19, 2021 • edited

Choose a reason for hiding this comment

csisoap commented Jan 17, 2021 • edited

em92 commented Jan 22, 2021

csisoap commented Jan 23, 2021 • edited

Spraynard commented Jan 24, 2021

em92 commented Jan 25, 2021

csisoap commented Jan 29, 2021

hollowleviathan commented Jan 29, 2021

em92 commented Jan 29, 2021

Spraynard commented Feb 4, 2021

hollowleviathan commented Jul 13, 2020 •

edited

csisoap commented Jul 17, 2020 •

edited

Spraynard commented Dec 25, 2020 •

edited

hollowleviathan commented Dec 26, 2020 •

edited

Spraynard commented Dec 27, 2020 •

edited

csisoap commented Jan 5, 2021 •

edited

csisoap commented Jan 10, 2021 •

edited

csisoap commented Jan 11, 2021 •

edited

csisoap Jan 19, 2021 •

edited

csisoap commented Jan 17, 2021 •

edited

csisoap commented Jan 23, 2021 •

edited