Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loupe doesn't always dismiss #26

Merged
merged 4 commits into from
Jul 19, 2013
Merged

Loupe doesn't always dismiss #26

merged 4 commits into from
Jul 19, 2013

Conversation

RSully
Copy link
Owner

@RSully RSully commented Jul 15, 2013

To reproduce on the view controller branch:

  • Press and hold on the color picker view
  • With another finger tap a button to push another view controller to the stack
  • Let go of where the loupe was being held down
  • Tap the back button and notice the loupe is still open

@ghost ghost assigned RSully Jul 15, 2013
@RSully
Copy link
Owner Author

RSully commented Jul 15, 2013

By checking the value of self.window within didMoveToWindow we can remove the loupe when no window is present.

This branch also includes some performance enhancements within didMoveToWindow that prevent us from rerunning genBitmap if the old size is the same as the new size.

This branch also includes the commits I had tested separately to move the demo into a UIViewController subclass and include a button to push more to the nav stack for testing performance.

@RSully RSully mentioned this pull request Jul 15, 2013
RSully added a commit that referenced this pull request Jul 19, 2013
Fix issue where Loupe doesn't always dismiss. Also changed demo app.
@RSully RSully merged commit 6ad4966 into master Jul 19, 2013
RSully added a commit that referenced this pull request Jul 19, 2013
Fix issue where Loupe doesn't always dismiss. Also changed demo app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant