Image picker support #31
Conversation
…mportant now that we are using a custom image
| _rep = [[ANImageBitmapRep alloc] initWithSize:newSize]; | ||
| } else if (_customImage) { | ||
| _rep = [[ANImageBitmapRep alloc] initWithImage:_customImage]; | ||
| [_rep setSizeFillingFrame:newSize]; |
There was a problem hiding this comment.
This should probably be in the background
Conflicts: RSColorPicker/ColorPickerClasses/RSColorPickerView.h RSColorPicker/ColorPickerClasses/RSColorPickerView.m RSColorPicker/TestColorViewController.m
|
This is pretty broken right now given the "state" concept we implemented. |
|
I can see why the new state stuff has broken this now I've had a look through the code. I reckon this would be quite a useful addition if it can be made to work with the new code. |
|
Yeah I haven't lost hope for this yet. A few solutions come to mind:
/ping @unixpickle |
|
I guess the cleanest option is potentially no.3. That keeps the logic in the same class etc and should result in less changes to RSColorPickerView |
|
If we made a state base class and then subclassed it for HSV and Live states that would possibly work. I'll look into it when I'm free. |
|
Even an |
This branch is a testing ground for adding custom-image support as suggested in #29.