Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][bouffalo] add pwm & rtc & wdt devices #7122

Merged
merged 8 commits into from
Mar 31, 2023

Conversation

WCX1024979076
Copy link
Contributor

@WCX1024979076 WCX1024979076 commented Mar 29, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

为bl808芯片增加pwm、rtc和wdt驱动支持。

你的解决方案是什么 (what is your solution)

增加 drv_rtc、drv_pwm和drv_wdt相关驱动文件

在什么测试环境下测试通过 (what is the test environment)

目前在bl808芯片上运行相关样例测试通过。

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023

CLA assistant check
All committers have signed the CLA.

@BernardXiong BernardXiong changed the title add pwm & rtc & wdt devices [bsp][bouffalo] add pwm & rtc & wdt devices Mar 29, 2023
bsp/bouffalo_lab/bl808/m0/.config Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/Kconfig Outdated Show resolved Hide resolved
@mysterywolf
Copy link
Member

emmm 你只修改了Kconfig,但是.config已经设置为y了

bsp/bouffalo_lab/bl808/m0/rtconfig.h Outdated Show resolved Hide resolved
Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交PR 把这些问题处理掉就应该可以合并了!

bsp/bouffalo_lab/bl808/m0/applications/wdt_sample.c Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/drv_pwm.c Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/drv_rtc.c Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/drv_wdt.c Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/drv_pwm.c Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/drv_rtc.c Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/drv_rtc.c Outdated Show resolved Hide resolved
bsp/bouffalo_lab/libraries/rt_drivers/drv_pwm.h Outdated Show resolved Hide resolved
@mysterywolf mysterywolf merged commit fb09316 into RT-Thread:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants