Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug] rename RT_DEBUGING_INIT -> RT_DEBUGING_PRE_INIT #7920

Closed
wants to merge 1 commit into from

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Aug 5, 2023

set default as n

默认需要设置为n 否则上电会打印一坨

image

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@BernardXiong
Copy link
Member

有些懵,这块是有些反复,或者下次提交前定几个bsp是一定需要测试验证的?

@mysterywolf
Copy link
Member Author

恩是的,这个PR验证没有问题了的

@@ -203,6 +203,10 @@ menuconfig RT_USING_DEBUG
default y

if RT_USING_DEBUG
config RT_DEBUGING_PRE_INIT
bool "Enable debugging of components pre-initialization"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个pre怎么理解呢?预先初始化?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯 或者你看看什么名字比较合适?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我是感觉加个pre也没意义, 因为这个本身就是一个自动初始化的机制。

@mysterywolf mysterywolf marked this pull request as draft August 17, 2023 05:27
@mysterywolf mysterywolf closed this Nov 9, 2023
@mysterywolf mysterywolf deleted the debug branch November 9, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants