Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add menuconfig check #7922

Closed
wants to merge 4 commits into from

Conversation

supperthomas
Copy link
Member

@supperthomas supperthomas commented Aug 6, 2023

拉取/合并请求描述:(PR description)

[
CI test

#7918

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@supperthomas
Copy link
Member Author

这个等issue解决了再合

@supperthomas
Copy link
Member Author

if ARCH_ARMV8 && ARCH_CPU_64BIT
    source "$RTT_DIR/libcpu/aarch64/Kconfig"
endif

这个只能保证menuconfig的时候不显示,但是如果找不到这个Kconfig,menuconfig还是会报错,所以scons --dist 会报错。

如果暂时没有解决办法,可以先去掉。后面让PR的小伙伴再尝试添加。

@supperthomas
Copy link
Member Author

#7918

@mysterywolf mysterywolf marked this pull request as draft September 14, 2023 13:11
@supperthomas supperthomas marked this pull request as ready for review September 18, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant