Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcpu][aarch64] Fixed the rt_hw_secondary_cpu_bsp_start() bug #8898

Merged
merged 3 commits into from
May 8, 2024

Conversation

liYony
Copy link
Contributor

@liYony liYony commented May 1, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

解决libcpu/aarch64中secondary cpu启动函数rt_hw_secondary_cpu_bsp_start中对gic进行重新初始化出现的问题。

描述如下:

在未修改代码之前,rt_hw_secondary_cpu_bsp_start函数会调用rt_hw_interrupt_init函数来对gic进行初始化,但是调用rt_hw_interrupt_init来初始化gic会出现两个问题:

  • 会调用rt_memset清空isr_table[]数组里面的内容。将会造成系统在初始化过程中调用rt_hw_interrupt_install注册的中断处理函数失效。
  • 会调用arm_gic_dist_init重新初始化gic分发器,该函数会失能所有中断。

所以secondary cpu使用rt_hw_interrupt_init函数对gic初始化是不妥的。

你的解决方案是什么 (what is your solution)

rt_hw_interrupt_init函数中部分代码抽出来。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

qemu-virt64-aarch64

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@BernardXiong BernardXiong requested a review from polarvid May 8, 2024 01:28
@polarvid
Copy link
Contributor

polarvid commented May 8, 2024

qemu aarch64 bsp 维护的 rt_hw_secondary_cpu_bsp_start 感觉可以迁移到 DD2.0 的这个实现。

@BernardXiong BernardXiong merged commit dbf8a26 into RT-Thread:master May 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants