Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hospital Projection Update #96

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Hospital Projection Update #96

wants to merge 2 commits into from

Conversation

yu-peng
Copy link
Collaborator

@yu-peng yu-peng commented Apr 19, 2020

[Wait to merge after important demos/meetings]

Updated hospitalization projection data from https://covidactnow.org/us/ny/county/new_york_county. The curve seems to be flattened compared to the data we used before. Note that a test needs to be updated too since it extends into the dates whose projections were updated.

Also, note that we are using the lowest curve of the three that assumes strict stay at home order, and continues with the total beds available number even after the projection falls below the capacity to ensure that we won't underestimate the demand.

image

@yu-peng yu-peng requested a review from rcoh April 19, 2020 23:54
Copy link
Member

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pass the model file in as a parameter with the default param set to the current model? Then we won't need to update the tests.
(You would just add new models instead of updating the old one)

@yu-peng
Copy link
Collaborator Author

yu-peng commented Apr 21, 2020

Maybe pass the model file in as a parameter with the default param set to the current model? Then we won't need to update the tests.
(You would just add new models instead of updating the old one)

Yes! Trying to add a fix in ac72879. Would it work (keeping multiple versions of the projection in the repo but use different ones in testing and deployment)?

@rcoh
Copy link
Member

rcoh commented Apr 21, 2020 via email

@yu-peng
Copy link
Collaborator Author

yu-peng commented Apr 21, 2020

FYI it sounds like we're moving to a flat model

On Mon, Apr 20, 2020, 8:03 PM yu-peng @.***> wrote: Maybe pass the model file in as a parameter with the default param set to the current model? Then we won't need to update the tests. (You would just add new models instead of updating the old one) Yes! Trying to add a fix in ac72879 <ac72879>. Would it work (keeping multiple versions of the projection in the repo but use different ones in testing and deployment)? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#96 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYKZ4VDJRWPFVOOOS5Q3DRNTPEXANCNFSM4MMAFJSQ .

Yeah....will leave the update here then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants