Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many ApplySupportmask in CG? #85

Closed
SimonRit opened this issue Mar 1, 2017 · 1 comment
Closed

Too many ApplySupportmask in CG? #85

SimonRit opened this issue Mar 1, 2017 · 1 comment

Comments

@SimonRit
Copy link
Collaborator

SimonRit commented Mar 1, 2017

I have reviewed this code (for a new dev) and it feels that there are too many ApplySupportMask in the CG. It would be nice to check if we can reduce this. It would also be nice to let the mask filters appear in the documentation graph with dashed line to indicate that they are optional.
cyrilmory added a commit that referenced this issue Mar 9, 2017
@cyrilmory
Merge pull request #92 from cyrilmory/master
419a718 
Fixed issues #85, #88 and #89
@cyrilmory
Copy link
Contributor

ApplySupportmask has been replaced with proper filters. They now appear in the documentation graphs, though not with dashed lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonRit @cyrilmory