-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
knowledge_level on all edges? #358
Comments
April 1 deadline to get this coded and deployed. |
Steve: look in the Biolink model to see if we can get the controlled vocabulary for knowledge_level |
Here is the schema that we will need to implement. There are actually two new edge properties, |
I'm hearing that we should plan our work to aim to have this rolled out in a new build of RTX-KG2 KP and tested in CI (and ready to deploy to ITRB TEST) by mid-March (final date to be announced at the relay next week). |
Lili and I are envisioning a new module that processes the KG2 edges json-lines file, downstream of
|
TBD: we will need to come up with a mapping strategy (which may be based on yet another YAML file) to determine what values should be put, instead of "not_provided". |
We are hoping to get this as KG2.10.Xc into the Translator release that takes place after the Eel release (which would probably mean a late June deadline for an ARAX based on KG2.10.Xc to be requested to be deployed into ITRB TEST. Which, in turn, would mean that KG2.10.Xpre would need to be built and validated correct for this issue by mid-May. We are aiming to do the treats refactor work (#373) before this, i.e., in the Eel release. |
@saramsey Do we need this in an edge_dict['agent_type'] = agent_type_map[primary_knowledge_source]
edge_dict['knowledge_level'] = knowledge_level_map[primary_knowledge_source] |
@saramsey Are we currently expected to fulfill the short term or long term specification on https://github.com/NCATSTranslator/ReasonerAPI/blob/master/ImplementationGuidance/Specifications/knowledge_level_agent_type_specification.md? |
@ecwood no I don't think in KG2pre, we need it in an edge attributes list. It could be two new edge properties But yes, @ecwood, at this point, Translator has moved to implement the long-term spec, i.e., each edge needs to have a |
yes, adding |
Per my exchange with Sierra, while the
|
From Tyler's post in Architecture today:
The text was updated successfully, but these errors were encountered: