-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some NCBIGene records should have biolink category "GenomicEntity" #1220
Comments
In addition to correctly setting the biolink category, we should prepend "Genetic locus for " to the |
looks like this change (for the most part) made it into kg2.5.2.
However,
|
@dkoslicki @edeutsch can you take a look at the above comment and let me know if you would like additional adjustments? |
Thanks! I think we wanted the prefix "Genetic locus associated with " on the |
Okay, I've added a fix for this! It's in aacf9c2 ; I mistyped the issue number in my commit message, hence the lack of traditional linkage :) this should appear in the next kg2 build. |
Great, looks like there is nothing for me to do here, as @edeutsch has communicated what specifically is needed (i.e., on the |
Also, I think some NCBIGene records should have the biolink category "microRNA": Ex.
This is labeled as a gene, but it is a microRNA (it's xref is |
The output of the cypher: is 1915. |
I think it hinders our reasoning on KG2, yes, so a fix would be appreciated! |
The microRNA issue is addressed in 3378f83 (forgot to tie that commit to this issue) |
Okay looks like the naming portion of this is fixed in kg2.6.0:
closing it out, as I think 1379 covers the microRNA stuff :) |
Example:
NCBIGene:780896
.Note that under the "General Gene Information" section, it has the property "phenotype only". I think in that case it makes sense to give it a biolink category
biolink:GenomicEntity
which is our closest Biolink approximation for "locus". I think this would require a fix inncbigene_to_tsv_to_kg_json.py
.See issue #1213 which first brought this issue to my attention.
The text was updated successfully, but these errors were encountered: