Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonymization issue with XDTD #1891

Closed
dkoslicki opened this issue Aug 15, 2022 · 2 comments
Closed

Synonymization issue with XDTD #1891

dkoslicki opened this issue Aug 15, 2022 · 2 comments

Comments

@dkoslicki
Copy link
Member

From one of the standups, for the creative mode query:

{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": [
                        "MONDO:0005300"

                    ],
                    "categories": [
                        "biolink:Disease"
                    ],
                    "name": "chronic kidney disease"
                },
                "n1": {
		             "categories":[
                         "biolink:ChemicalEntity"
                        ]
                }
            },
            "edges": {
                "e0": {
                    "knowledge_type": "inferred",
                    "subject": "n1",
                    "object": "n0",
                    "predicates":[
                        "biolink:treats"]
                }
            }
        }
    }
}

If you use MONDO:0005300, we get no xDTD results, but if we use MONDO:0004375, we do get results. According to our synonymizer, those two should be synonymous, and MONDO:0004375 the preferred curie. So I don't know why the 5300 mondo isn't been replaced with the 4375 one in xDTD.

@chunyuma
Copy link
Collaborator

This issue should be fixed now. I tested this query locally and it works. Once it still works in production, we can close it.

@chunyuma
Copy link
Collaborator

It was fixed based on the test in production. So I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants