Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For windows, allocator/deallocator must be in the same module (cf blog post)
Thus, Numpy arrays cannot be allocator by numpy and deallocated by armadillo.
To fix that,
steal_copy_array
has been rewritten to be able to build numpy arrays using data allocated by armadillo.This behavior is set using
allow_foreign_allocator
variable insteal_copy_array
.Unfortunately, VS 16 (2019) seems to not enable NRVO inside
p_arr_to_cube
function. This impliesCube
object copy (including internal data) whenstrict
is true. That's why, two tests have been disabled on WIN32 intest_arr_to_mat_native.cpp
.