Bug: fresh-install-script not detecting packages

[emmanuelkring]

Description

When running the fresh install script after fresh install on Ubunutu 20.04 (and probably on 18.04), ROS is detected as already installed.

Probable reason

Seems to be two problems when checking for packages in the lines on the form of:

if `apt list --installed 2>/dev/null | grep -iqwe ^$1/`; then
#package is not installed

The first is that apt list --installed 2>/dev/null | grep -iqwe ^ros-melodic-desktop/ has exit status 1 (i.e. finds nothing) even if the package is installed. This seems to be due to the forward slash at the end. Secondly the if statement seems to check if the command was successful or not i.e. true if grep found something even though it has exit status 0 if it did.

[emmanuelkring]

Still not working since ROS packages needs to be added to the source list before doing the check if ROS is installed otherwise it thinks the package does not exist.

[emmanuelkring]

Tested from fresh install on Ubuntu 20.04