move fastHVAC to obsolete package #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DaJansenGit
commented
Feb 4, 2021
•
DaJansenGit
commented
- conversion script generated
- package moved
- add obsolete flag and icon to package
- Closes Move FastHVAC to obsolete package #1074
- Closes FastHVAC heat pump does not run in OpenModelica #864
- Closes makeFastHvacGreatAgain #790
- Closes B13 integration #751
- conversion script generated - package moved - add obsolete flag and icon to package
|
we can also close this branch afterwards: |
This message will be overwritten by specific messages but makes sure that some message is displayed if a obsolete model is used.
Dawac
reviewed
Mar 2, 2021
There was a problem hiding this comment.
Kleine Unstimmigkeiten bei Wärmeübergangsfunktionen gefunden, da sind ein paar rausgefallen. Ist im Review markiert. Aus der Aixlib ist außerdem AixLib.Utilities.HeatTransfer.HeatConvPipeInside in Obsolete verschoben worden, ich verstehe nicht ganz ob das beabsichtigt war.
AixLib/Obsolete/YearIndependent/FastHVAC/Components/Pipes/BaseClasses/PipeBase.mo
Show resolved
Hide resolved
AixLib/Obsolete/YearIndependent/FastHVAC/Components/Pipes/DynamicPipe.mo
Show resolved
Hide resolved
AixLib/Obsolete/YearIndependent/FastHVAC/Components/Pipes/DynamicPipe.mo
Show resolved
Hide resolved
AixLib/Obsolete/YearIndependent/FastHVAC/Components/Storage/BaseClasses/HeatingCoil.mo
Show resolved
Hide resolved
Dawac
reviewed
Mar 2, 2021
…Components.Pipes.BaseClasses.PipeBase
…ependent.FastHVAC.Components.Pipes.DynamicPipe
…ependent.FastHVAC.Components.Pipes.DynamicPipeAggregated
…omponents.Storage.BaseClasses.HeatingCoil
…omponents.HeatExchangers.BaseClasses.ML_thermal_delta
Dawac
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.