Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in typePattern validation #180

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

richardmarston
Copy link
Collaborator

Changed the line as proposed in the issue definition.

Copy link
Collaborator

@tstorek tstorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardmarston thank your very much. Could you please add a little test_case for this :) Thanks

@tstorek tstorek linked an issue Dec 19, 2022 that may be closed by this pull request
@richardmarston
Copy link
Collaborator Author

I have written a Dockerfile that runs tests/utils/test_filter.py. The output is this:

 {
  "LOG_LEVEL": "ERROR",
  "CB_URL": "http://localhost:1026",
  "IOTA_URL": "http://localhost:4041",
  "IOTA_JSON_URL": "http://localhost:4041",
  "IOTA_UL_URL": "http://127.0.0.1:4061",
  "QL_URL": "http://127.0.0.1:8668",
  "MQTT_BROKER_URL": "mqtt://127.0.0.1:1883",
  "CI_JOB_ID": null,
  "FIWARE_SERVICE": "filip",
  "FIWARE_SERVICEPATH": "/41f4e71481164dd08bba18aa136c0a3f"
}

  • Does this output indicate that the tests have been run correctly?
  • Should I add the test case to test_filter.py?

@tstorek
Copy link
Collaborator

tstorek commented Dec 19, 2022

@richardmarston ideally, your test should be located in the model section of the tests. If you have your own FIWARE instance running you can simple use your local instance:

  1. Copy and rename the tests/TEMPLATE_ENV file to .env (don't commit that file)
  2. Fill in all your parameters
  3. Run the tests on your local machine. Filip will then automatically search for the .env file.
  4. Commit your test. This will trigger our pipeline and run the tests with our server instance. As you can see above.

Please, contact me directly if you require help with the testing instance.

@tstorek tstorek added the bug Something isn't working label Dec 20, 2022
@djs0109 djs0109 self-assigned this Jan 20, 2023
@djs0109 djs0109 merged commit 85accf8 into master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug in Filip's typePattern validation.
4 participants