-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsable ui #183
Open
gregveres
wants to merge
4
commits into
Raathigesh:master
Choose a base branch
from
gregveres:collapsableUI
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Collapsable ui #183
Commits on Feb 8, 2020
-
added repeatable ID generation for jest elements
This is the first step to collapsable describe blocks in the UI. This change modifies the way that Ids are assigned to the jest blocks that are passed to the UI. Before this change, every time the file was refreshed, the Id assigned to a block would be brand new and different. With this change we keep track of the Ids that have been assigned and we re-use them when we recognize that the element is the same as before. This will allow us in the UI to keep track of which describe blocks have been collapsed and when we revisit the page or rerun the tests, the describe blocks that were collapsed will remain collapsed. This is just the server side of that change.
Greg Veres committedFeb 8, 2020 Configuration menu - View commit details
-
Copy full SHA for 8e440d5 - Browse repository at this point
Copy the full SHA 8e440d5View commit details
Commits on Feb 9, 2020
-
Added collapsing describe blocks
This checkin adds the ability to collapse the describe blocks for the test result. The collapsed state is stored per describe block in a static class and updated each time the user toggles a block. The collapse state storage is small, only storing data for the describe blocks that are actually toggled. When a test is re-run, if there are failures in a describe block that is collapsed, it is automatically opened. I also fixed the display of the status icon beside describe blocks. Before this change it was always green. Now it is red when one of its tests fail. I am pretty sure this was a bug before because as soon as I changed the status to failed for the describe block, it changed the colour to red, indicating that the testIndicator component already handled the case but wasn't being passed the correct values. I believe this change fits in with the style of the existing component. I retained the functional component style by using React hooks. Unexpectantly, I had to use the useEffect tied to changing of the results variable. This was necessary to get the describe block to open after a test run if a test within it failed. I also had to change the implementation of allChildrenPassing. it now recursively looks at the children where it didnt before. Also, I made it so that clicking on the entire bar collapsed or expands the block rather than just the +/- div.
Greg Veres committedFeb 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 89c04ac - Browse repository at this point
Copy the full SHA 89c04acView commit details -
fixed issue where tests with the same name would share the same failu…
…re results Since the UI was matching results with tests by the test title, it was picking the wrong test result for all but the the first test with the duplicated name. This fix uses the previous change for collapsing describe blocks. The Ids that the backend assigned to the tests, are propogated through to the UI with the test results with this change. This allows the UI to use the id to match the test results with the tests. The end result is that a user can have the same named test in multiple locations in the test file and the UI will always match up the correct results with the tests. The id field had to be added to the test item result entry and the queries the UI sends had to include the field. Assigning Ids to the tests in the test result is fairly efficient because it can use the property of the test results that tests are grouped by under their describe block. So on each iteration of the loop, we first check to see if the existing idManaager is still valid and if it is, we just use that one rather than searching for the right idManager to use.
Greg Veres committedFeb 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 8e67b5c - Browse repository at this point
Copy the full SHA 8e67b5cView commit details
Commits on Apr 17, 2020
-
added ability to click on an error and open the offending file in VSCode
This adds the ability to quickly jump to the error in the source file on a failing test. This fixes issue Raathigesh#186
Greg Veres committedApr 17, 2020 Configuration menu - View commit details
-
Copy full SHA for 9fe44e4 - Browse repository at this point
Copy the full SHA 9fe44e4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.