[RAC-6681] Lock down NPM modules #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanchongyizu
force-pushed
the
bugfix/add-package-lock-json
branch
2 times, most recently
from
4b8bf7c
to
63b6dd5
Compare
lanchongyizu
force-pushed
the
bugfix/add-package-lock-json
branch
from
63b6dd5
to
c5247a7
Compare
* Add publishable npm-shrinkwrap.json, which is repurposed from package-lock.json.
* Not lock down the dependent on-core/on-tasks, so don't add commit hash or version to on-core/on-tasks.
The benefits:
* Don't need to update npm-shrinkwrap.json every time when on-core/on-tasks has a new commit.
* Ease the dependent PRs merging.
* Install npm@5.6.0 in travis-ci which is the same as concourse-ci.
lanchongyizu
force-pushed
the
bugfix/add-package-lock-json
branch
from
c5247a7
to
587bb28
Compare
nortonluo
approved these changes
Apr 24, 2018
iceiilin
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benefits:
Please refer to RackHD/on-tasks#585 and https://rackhd.atlassian.net/browse/RAC-6681 for details.
@RackHD/corecommitters @iceiilin @nortonluo