add validation for users #207
Conversation
| if(user.sshKey){ | ||
| expect(user.sshKey).to.be.a('string'); | ||
| } | ||
| }) |
|
@RackHD/corecommitters please review. |
|
test this please |
|
jenkins: test this please |
| .to.throw('username must be a string'); | ||
| }); | ||
|
|
||
| it('should throw error when username is not valid', function() { |
There was a problem hiding this comment.
This description is same with line#290, it's better to change to a different one.
|
@PengTian0 : This link (http://vbird.dic.ksu.edu.tw/linux_basic/fedora_4/0410accountmanager-fc4.php#account_id) is in Chinese, you'd better use a link in English, so every reviewer can understand. |
|
+1 |
|
👍 @jlongever, seems @PengTian0 should also be added into the whitelist, so that the Jenkins will work. |
|
@yyscamper Here is my post describing how this works https://groups.google.com/forum/#!searchin/rackhd/Jenkins/rackhd/lU6DjRKWW5I/-hiqFFm1BgAJ |
|
@jlongever , I definitely forgot this. OK, thanks. I can handle it by myself. |
|
+1 |
|
@yyscamper i just changed the link to |
|
Jenkins, ok to test |
update publishGraphFinished parameters
validate the input users date. user date should meet the following requirements:
http://askubuntu.com/questions/137126/how-are-the-values-of-uid-generated
@yyscamper @iceiilin @panpan0000