[RAC-6176] add unit test for wsman-tool and wsman base job #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BUILD on-tasks #285 : FAILURE BUILD on-tasks #285 Error Logs ▼Test Name: Should send request to smi service successfully Error Details: undefined (string) is required Stack Trace: AssertionError: undefined (string) is required at AssertService.(anonymous function) [as string] (node_modules/on-core/lib/common/assert.js:30:28) at new WsmanTool (lib/utils/job-utils/wsman-tool.js:9:689) at Context.<anonymous> (spec/lib/jobs/dell-wsman-bios-spec.js:130:25)Test Name: Should fail to get respone from smi service |
nortonluo
approved these changes
Oct 26, 2017
| httpStatusCode: 200, | ||
| body: '{"a":1,"b":2}' | ||
| }); | ||
| setupRequest = sandbox.stub(HttpTool.prototype, 'setupRequest').resolves(); |
There was a problem hiding this comment.
Suggest use different variable name eg. MockRequest。
| port: parsed.port, | ||
| protocol: parsed.protocol.replace(':','').trim(), | ||
| verifySSL: options.verifySSL, | ||
| recvTimeoutMs: options.recvTimeoutMs |
There was a problem hiding this comment.
add || 30000？As default timeout setting
There was a problem hiding this comment.
It is set in clientRequest.
lanchongyizu
force-pushed
the
wsman-tool-ut
branch
from
048fe00
to
f14b5ac
Compare
anhou
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As the RACADM replacement work squad, we need to work on common wsman-tools functionality, so that everyone can focus on their own tasks.
Details
Reviewers
@RackHD/corecommitters @nortonluo @yaolingling