Add additional data to node discovered event #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 27, 2017
|
|
||
| return self._getHwInfoCatalog() | ||
| .then(function(dmi) { | ||
| var hwInfo = dmi['System Information'] |
gavin-scott
commented
Oct 27, 2017
| }).then(function (catalog) { | ||
| if (!catalog) { | ||
| return Promise.reject( | ||
| new Error('Could not find dmi catalog data.')); |
There was a problem hiding this comment.
@keedya mentioned in slack we probably don't want to fail here if the data isn't available. I can clean this up tomorrow to make sure missing catalog data doesn't fail this job.
gavin-scott
force-pushed
the
addl-discovery-data
branch
from
3df9edc
to
3b01e05
Compare
Include the serial number, manufacturer and product from the dmi catalog.
gavin-scott
force-pushed
the
addl-discovery-data
branch
from
3b01e05
to
d630b94
Compare
|
@keedya updated this with better error handling and a test. |
|
@gavin-scott looks good. Will run our system testing and run it by the team. |
|
Adding more reviewere: |
geoff-reid
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the serial number, manufacturer and product from the
dmi catalog.