-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A fix for on-tasks to be able to render workflow #541
Conversation
…objects. Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
lib/task.js
Outdated
} | ||
}).join(''); | ||
}); | ||
mappedValues.forEach(function (element){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'element' is defined but never used.
lib/task.js
Outdated
if(typeof type === 'string' || type instanceof String || type == null) { | ||
isString = true; | ||
} else { | ||
isString = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
lib/task.js
Outdated
var rendered = self.renderString(item.n, context, depth, 50); | ||
return rendered; | ||
var type = _.get(context, item.n); | ||
if(typeof type === 'string' || type instanceof String || type == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected '===' and instead saw '=='.
lib/task.js
Outdated
source.forEach(function (element) { | ||
renderedValue.push(Hogan.parse(Hogan.scan(element))); | ||
}); | ||
return renderedValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
Signed-off-by: Massarrah Tannous <massarrah.tannous@emc.com>
Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
…nto renderingFix Signed-off-by: Massarrah Tannous <massarrah.tannous@emc.com>
This is a fix for on-tasks to be able to render objects and array of objects...
Signed-off-by: Bala Balakumaran bala.balakumaran@dell.com