On network tasks #542
Merged
On network tasks #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects. Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
Signed-off-by: Massarrah Tannous <massarrah.tannous@emc.com>
Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
…nto renderingFix Signed-off-by: Massarrah Tannous <massarrah.tannous@emc.com>
get switch config get switch version update switch firmware on-network login Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
Signed-off-by: Massarrah Tannous <massarrah.tannous@emc.com>
houndci-bot
reviewed
Nov 3, 2017
lib/jobs/rest-job.js
Outdated
| self.context.outputs ={}; | ||
| } | ||
|
|
||
| self.context.outputs[self.taskName] = {"restData":""} |
Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
… into on-network-tasks
Discovery issue with pollers Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
keedya
approved these changes
Nov 14, 2017
anhou
reviewed
Nov 14, 2017
| @@ -0,0 +1,26 @@ | |||
| // Copyright 2016, EMC, Inc. | |||
There was a problem hiding this comment.
keep consistent with other files, 'EMC' -> 'Dell EMC', and 2017
anhou
reviewed
Nov 14, 2017
| @@ -0,0 +1,26 @@ | |||
| // Copyright 2017, EMC, Inc. | |||
There was a problem hiding this comment.
keep consistent with other files, 'EMC' -> 'Dell EMC'
anhou
reviewed
Nov 14, 2017
| @@ -0,0 +1,20 @@ | |||
| // Copyright 2016, EMC, Inc. | |||
There was a problem hiding this comment.
keep consistent with other files, 'EMC' -> 'Dell EMC' and 2017
anhou
reviewed
Nov 14, 2017
| options: { | ||
| endpoint: '{{options.endpoint}}', | ||
| loginToken: '{{options.loginToken}}', | ||
| url: 'http://{{ server.onNetwork.url }}/switchConfig', |
There was a problem hiding this comment.
it's better that server.onNetwork.url include http://, http or https is also part of URL definition, and it's also good for extension
anhou
reviewed
Nov 14, 2017
| options: { | ||
| endpoint: '{{options.endpoint}}', | ||
| loginToken: '{{options.loginToken}}', | ||
| url: 'http://{{ server.onNetwork.url }}/switchVersion', |
anhou
reviewed
Nov 14, 2017
| injectableName: 'Task.Post.Login.On-network', | ||
| implementsTask: 'Task.Base.Rest', | ||
| options: { | ||
| url: 'http://{{ server.onNetwork.url }}/login', |
anhou
reviewed
Nov 14, 2017
| @@ -0,0 +1,28 @@ | |||
| // Copyright 2016, EMC, Inc. | |||
anhou
reviewed
Nov 14, 2017
| switchModel: '{{options.switchModel}}', | ||
| firmwareImages:'{{options.firmwareImages}}', | ||
| loginToken: '{{options.loginToken}}', | ||
| url: 'http://{{ server.onNetwork.url }}/updateSwitch', |
Signed-off-by: Bala Balakumaran <bala.balakumaran@dell.com>
anhou
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.