add dell-wsman-reset-components task/base-task/job #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanchongyizu
force-pushed
the
story/RAC-6481
branch
from
36b1bcb
to
fbd08e4
Compare
This was referenced Nov 16, 2017
nortonluo
reviewed
Nov 16, 2017
| @@ -8,7 +8,7 @@ var di = require('di'); | |||
| module.exports = DellWsmanDiscoveryJobFactory; | |||
There was a problem hiding this comment.
I think it's better to put wsman-discovery Refine in another PR(Including the unit test). Although this bios reset PR depends on wsman discover function to find a valid node. But from unit test perspective, there is no tight coupling.
nortonluo
reviewed
Nov 16, 2017
| "type": "array", | ||
| "description": "A list of components that will be reset", | ||
| "items": { | ||
| "type": "string", |
There was a problem hiding this comment.
Use enum could be better.
The parameter could only be bios, diag, drvpack, idrac and lcdata
There was a problem hiding this comment.
The component name is case-insensitive, it can be BiOs.
lanchongyizu
force-pushed
the
story/RAC-6481
branch
2 times, most recently
from
4298a4a
to
0bd3bbd
Compare
|
BUILD on-tasks #151 : FAILURE |
lanchongyizu
force-pushed
the
story/RAC-6481
branch
from
0bd3bbd
to
79773cd
Compare
yaolingling
approved these changes
Nov 21, 2017
nortonluo
approved these changes
Nov 21, 2017
anhou
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Based on the previous investigation result, develop to port Graph.Dell.Racadm.ResetComponents and /Systems/{identifier}/Bios.ResetBios to use WSMAN API.
https://rackhd.atlassian.net/browse/RAC-6481
Done
add dell-wsman-reset-components task/base-task/job
@RackHD/corecommitters @nortonluo