RAC-6491 : dell wsman add volume feature implementation with WSMAN API #563
Conversation
| newNode.appendChild(textNode); | ||
| ele.appendChild(newNode); | ||
| } | ||
| for(var i = 0; i < enclosureIndex.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| var fqddName = 'Disk.Virtual:' + driver.slice(driver.lastIndexOf(':')+1, driver.length); | ||
| ele.setAttribute('FQDD', fqddName); | ||
| doc.insertBefore(ele, components[insertIndex]); | ||
| for(var i = 0; i < attributes.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| for(var i = 0; i < index.length; i++){ | ||
| doc.documentElement.removeChild(components[index[i]]); | ||
| } | ||
| for(var i = 0; i< bayIndex.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| bayIndex.push(i); | ||
| } | ||
| } | ||
| for(var i = 0; i < index.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| "textContent": driversArray[i] | ||
| }); | ||
| } | ||
| for(var i = 0; i < components.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| } | ||
| ]; | ||
| var driversArray = drivers.split(','); | ||
| for(var i = 0; i < driversArray.length; i++){ |
| newNode.appendChild(textNode); | ||
| ele.appendChild(newNode); | ||
| } | ||
| for(var i = 0; i < enclosureIndex.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| var fqddName = 'Disk.Virtual:' + driver.slice(driver.lastIndexOf(':')+1, driver.length); | ||
| ele.setAttribute('FQDD', fqddName); | ||
| doc.insertBefore(ele, components[insertIndex]); | ||
| for(var i = 0; i < attributes.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| for(var i = 0; i < index.length; i++){ | ||
| doc.documentElement.removeChild(components[index[i]]); | ||
| } | ||
| for(var i = 0; i< bayIndex.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| bayIndex.push(i); | ||
| } | ||
| } | ||
| for(var i = 0; i < index.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| "textContent": driversArray[i] | ||
| }); | ||
| } | ||
| for(var i = 0; i < components.length; i++){ |
There was a problem hiding this comment.
'i' is already defined.
Unexpected use of '++'.
| } | ||
| ]; | ||
| var driversArray = drivers.split(','); | ||
| for(var i = 0; i < driversArray.length; i++){ |
| if(self.dell.shareFolder.shareType === 0){ | ||
| client = new NfsClient( | ||
| self.dell.shareFolder.address, | ||
|
|
| "raidLevel": { | ||
| "description": "Specify raidLevel for adding volume. default value: RAID 0", | ||
| "type": "string", | ||
| "enum": ["RAID 0","RAID 1", "RAID 5", "RAID 6", "RAID 10"] |
There was a problem hiding this comment.
change it's type to integer
| job.dell = configFile; | ||
| job.options = options; | ||
| Smb2Client.prototype.readFile.resolves(fileData); | ||
| expect(job.parseXmlFileForRAID()).to.be.fulfilled; |
| }; | ||
| job.options = options; | ||
| NfsClient.prototype.readFile.resolves(fileData); | ||
| expect(job.parseXmlFileForRAID()).to.be.fulfilled; |
Background
Based on the preceding investigation work (RAC-6212), add volume feature will be implemented with wsman API. One graph will be created which constains four tasks. The first task is used to get xml file for adding volume. The second task is used to update the xml file. The third task is used to add volume. The last task is used to update mongodb.
Reviewers
@anhou @nortonluo @lanchongyizu @AlaricChan