Adding one task to install debian and ubuntu #571
Conversation
| "OsName": { | ||
| "description": "The name of Linux OS based on LSB Distributor ID (debian, ubuntu)", | ||
| "type": "string", | ||
| "minLength": 1 |
There was a problem hiding this comment.
indent problem for both line 8 and line 11
There was a problem hiding this comment.
I cant find any problem with line 8 but i fixed the line 11
| @@ -319,6 +324,14 @@ | |||
| "type": "string", | |||
| "description": "Extra (persistent) kernel boot parameters", | |||
| "minLength": 1 | |||
| }, | |||
| "Timezone": { | |||
| "description": "The Timezone based on $TZ (Asia/Tehran)", | |||
There was a problem hiding this comment.
based on Asia/Tehran seems a little odd, suggest using UTC or local
There was a problem hiding this comment.
Its just example in description not a default value , if you do not set its utc by default .
| baseUrl: 'dists/{{ options.version }}/main/installer-amd64/current/images/netboot/ubuntu-installer/amd64', | ||
| version: 'stretch', | ||
| repo: '{{file.server}}/debian', | ||
| baseUrl: 'dists/stretch/main/installer-amd64/current/images/netboot/debian-installer/amd64', |
There was a problem hiding this comment.
a optional suggestion is to use the option template just like below, so even the version changes, the baseUrl can keep unmodified:
dists/{{options.version}}/main/installer-amd64/current/images/netboot/debian-installer/amd64
| baseUrl: 'dists/{{ options.version }}/main/installer-amd64/current/images/netboot/ubuntu-installer/amd64', | ||
| version: 'stretch', | ||
| repo: '{{file.server}}/debian', | ||
| baseUrl: 'dists/{{ options.version }}/main/installer-amd64/current/images/netboot/debian-installer/amd64', |
There was a problem hiding this comment.
We could change repo and baseUrl to
repo: '{{file.server}}/{{options.osName}}',
baseUrl: 'dists/{{ options.version }}/main/installer-amd64/current/images/netboot/{{options.osName}}-installer/amd64',
So that the payload only needs osName and version.
There was a problem hiding this comment.
good i will change this part
| "description": "The name of Linux OS based on LSB Distributor ID (debian, ubuntu)", | ||
| "type": "string", | ||
| "minLength": 1 | ||
| }, |
There was a problem hiding this comment.
We could limit the osName to "enum": [ "ubuntu", "debian" ].
| }, | ||
| "Ntp": { | ||
| "description": "The NTP server address", | ||
| "type": "string" |
There was a problem hiding this comment.
We could add minLength for both Timezone and Ntp.
There was a problem hiding this comment.
if i set minlength it means its a required option or not ?
There was a problem hiding this comment.
No, whether an options is required or not is defined in install-debian.json.
|
@Ara4Sh it looks like the codes has conflicts, and @lanchongyizu is on vacation, maybe reply you later about your feedback |
depends on: RackHD/on-tasks#571 . Adding Graph.InstallDebian to install both Debian and Ubuntu. Fixing Custom Partitioning : installPartitions in payload required following parameters : /boot , swap and / partition must be present or installation will be corrupted. ``` "installPartitions": [ { "mountPoint": "/boot", "size": "500", "fsType": "ext4" }, { "mountPoint": "swap", "size": "8192", "fsType": "swap" }, { "mountPoint": "/arash", "size": "10000", "fsType": "ext4" }, { "mountPoint": "/", "size": "auto", "fsType": "ext4" } ] ``` the auto value must be in the latest partition. 2- Fixing networkDevices the network devices wont work if you dont have vlans . 3- Adding timezone and Ntp support Tested with Debian Jessie, Debian Stretch, Ubuntu Xenial on HP Proliant Servers.
depends on: RackHD/on-taskgraph#346
Install Debian - Ubuntu with only one task: Task.Os.Install.Debian
osName is a new required variable with default value debian. we use this variable in following files :
to install ubuntu you have to create a payload file with following details :
current default values are :
Successfully tested with Debian Jessie, Debian stretch, ubuntu xenial on HP Proliant servers.