Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support release work #53

Closed
wants to merge 2 commits into from
Closed

Conversation

changev
Copy link
Member

@changev changev commented Oct 14, 2016

modify travis config

used

per PR-merge of master build deb and upload them to bintray, named on-tftp_1.1-1master-20160923181601Z.deb .

now

per PR-merge build on-tftp_1.2.3rc-20160923181601Z-125b07b.deb or on-tftp_1.2.2devel-20150923181601Z-535b07b.deb with deb_component "main", we call this ci-builds.
per push Tag build on-tftp_1.2.3.deb with deb_component "release", we call this release build
This feature will be applied on every repo in the future.
@RackHD/corecommitters @panpan0000 @PengTian0

@@ -1,4 +1,4 @@
on-tftp (1.1-1) unstable; urgency=low
on-tftp (1.2.3) UNRELEASED; urgency=low
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per Alan, in Debian rules, before code become a "release", here will be UNRELEASED.
when release , using "dch -r" , here will become unstable, indicate it's released

if [[ $DEBBRANCH =~ ^[0-9.]+$ ]]; then
export DCHOPTS="-r \"\""
else
export DCHOPTS="-v ${DEBBRANCH} -u low ${DEBPKGVER} -b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comment for reason why using "-b" (force build)


#modify bintray cfg
DEBBRANCH=$(./extra/gen-debbranch.sh)
if [[ $DEBBRANCH =~ ^[0-9.]+$ ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] it works. but this implementation depends on how another file extra/gen-debbranch.sh implements
" if [ "$SYMBOL" != "release" ]; then DEBBRANCH=xxxx"

say, if extra/gen-debbranch.sh changes the "~ ^[0-9.]+$ ", it tends to miss to change this file as well ...
do we have better way , to decouple ?

@rackhd-test-rel
Copy link

👍

@changev
Copy link
Member Author

changev commented Oct 20, 2016

test this please

@changev changev force-pushed the feature/support-release branch 10 times, most recently from d64b769 to c834145 Compare October 20, 2016 09:06
@JenkinsRHD
Copy link
Contributor

BUILD on-tftp #756 : ABORTED

BUILD on-tftp #756 Error Logs:

@changev
Copy link
Member Author

changev commented Oct 20, 2016

test this please

@rackhdmirror
Copy link

Build finished.

@rackhdmirror
Copy link

Build finished.

@rackhdmirror
Copy link

Build finished.

@changev changev closed this Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants