Table component #132
Table component #132
Conversation
| [] | ||
| [:div [:h2 "Table"]]) | ||
| [state] | ||
| (let [state-deref @state |
There was a problem hiding this comment.
Why does this get state injected/why isn't this just session state?
There was a problem hiding this comment.
(If the answer is "for the test"; rebind the state instead)
There was a problem hiding this comment.
Easier for testing I guess, is there something wrong with this approach?
There was a problem hiding this comment.
you can't get a parameter wrong if it doesn't exist
|
What the heck, codecov. |
| (def isClient (not (nil? (try (.-document js/window) | ||
| (catch js/Object e nil))))) | ||
|
|
||
| (def rflush r/flush) |
There was a problem hiding this comment.
Why does this get added here? We just didn't have client tests before today?
You might want to look at the equivalent code in shrieker because it cleans some of this up a little; e.g. not nil? is an antipattern &c
There was a problem hiding this comment.
There wasn't much to test before when it comes to actual generated markup and its reactivity. I'll take a look at shrieker, thanks
Adds some example data and sorted-table from wilson