ignoreFiles/includeFiles accepting Regex #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadValentin
requested changes
Jun 3, 2021
index.js
Outdated
| @@ -53,6 +53,26 @@ module.exports = function postcssPrefixSelector(options) { | |||
| }; | |||
| }; | |||
|
|
|||
| function ignoreFile(file, ignoreArr) { | |||
There was a problem hiding this comment.
I'd like to change the name of this function to be more descriptive of what it does, ex: isFileIgnored
index.js
Outdated
| }); | ||
| } | ||
|
|
||
| function includeFile(file, includeArr) { |
There was a problem hiding this comment.
Same as above, please make the name more descriptive, like isFileIncluded
There was a problem hiding this comment.
Also, both these functions do basically the same thing. Can you merge them into one and give it a descriptive name?
|
Hey @mellis481, I reviewed this PR and it looks good, just needs a few more tweaks. Do you think you'll have time to address the comments in the near future? Let me know, thanks! |
Reverts package-lock.json
RadValentin
approved these changes
Jun 16, 2021
Thanks for creating an awesome library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.