Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the imports of managers from models #217

Open
abhiabhi94 opened this issue Jul 19, 2021 · 0 comments
Open

Remove the imports of managers from models #217

abhiabhi94 opened this issue Jul 19, 2021 · 0 comments
Labels
bug Something isn't working technical debt
Milestone

Comments

@abhiabhi94
Copy link
Collaborator

Describe the bug

Currently, managers can be imported from models.

Steps To Reproduce

Something like this works:

from comment.models import CommentManager

Expected behavior

Managers should ideally not be available from the models. This was due to the namespace pollution caused by using * imports in __init__.py. #213 addresses the namespace pollution, but managers are still given there for backward compatibility. Remove these in v3.0.0.

@abhiabhi94 abhiabhi94 added the bug Something isn't working label Jul 19, 2021
@abhiabhi94 abhiabhi94 added this to the 3.0.0 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical debt
Projects
None yet
Development

No branches or pull requests

1 participant