fix: Namespace pollution caused by star imports #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiabhi94
force-pushed
the
fix/start-imports
branch
3 times, most recently
from
cf0c638
to
79a888a
Compare
Radi85
previously approved these changes
Jul 18, 2021
- use explicit imports and `__all__` to declare allowed list of public objects. - some imports are still provided for backward compatibility, they may be removed in a major version bump. - also, use correct packages for import of managers in tests.
abhiabhi94
force-pushed
the
fix/start-imports
branch
from
79a888a
to
52fe8dc
Compare
Radi85
approved these changes
Jul 19, 2021
|
Thanks Radico, for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__all__to declare allowed list of public objects.