Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Toggling of subscription button in js #178

Merged
merged 1 commit into from
Mar 26, 2021
Merged

fix: Toggling of subscription button in js #178

merged 1 commit into from
Mar 26, 2021

Conversation

abhiabhi94
Copy link
Collaborator

@abhiabhi94 abhiabhi94 commented Mar 25, 2021 •
edited
Loading

  • toggling only takes place when the button is present

fixes #175

@abhiabhi94
Copy link
Collaborator Author

This can't be merged before #177 fixes CI.

@abhiabhi94 abhiabhi94 requested a review from Radi85 March 25, 2021 15:51
@abhiabhi94 abhiabhi94 changed the title fix: Toggling of subscription Button in js fix: Toggling of subscription button in js Mar 25, 2021
@abhiabhi94
fix(Radi85#175): Toggling of subscription button in js
e72a3e7 
- toggling only takes place when the button is present
@Radi85 Radi85 merged commit b54ab2d into Radi85:develop Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radi85 Radi85 Awaiting requested review from Radi85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggling of follow button in javascript breaks replies when subscription is disabled
2 participants
@abhiabhi94 @Radi85