Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#210): Reduce chances of XSS injections #211

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

abhiabhi94
Copy link
Collaborator

@abhiabhi94 abhiabhi94 commented Jun 2, 2021

  • on the content field.

fixes #210

@abhiabhi94 abhiabhi94 force-pushed the fix/xss-injection-on-content branch 2 times, most recently from 9ef9862 to 53f43aa Compare June 14, 2021 14:35
Radi85
Radi85 previously approved these changes Jun 16, 2021
@Radi85
Copy link
Owner

Radi85 commented Jun 16, 2021

Great work!
@abhiabhi94 Could you please rebase your PR?

@abhiabhi94
Copy link
Collaborator Author

Hey @Radi85, this status reporting in taking too long on travis-ci. It maybe due to an issue at either end. Do you consider switching to GitHub actions? A lot of open-source repositories have migrated to it, and I too have had satisfactory experience.

Although, It maybe a backroom strategy by Microsoft to have this migration.

@Radi85
Copy link
Owner

Radi85 commented Jun 16, 2021

Hey @Radi85, this status reporting in taking too long on travis-ci. It maybe due to an issue at either end. Do you consider switching to GitHub actions? A lot of open-source repositories have migrated to it, and I too have had satisfactory experience.

I have no never used actions but I would not mind to migrate since we are facing issues with Travis. I will have a look at it as soon as I have a time.

Although, It maybe a backroom strategy by Microsoft to have this migration.

Microsoft 😆

@Radi85 Radi85 merged commit 3852bff into Radi85:develop Jun 16, 2021
@abhiabhi94
Copy link
Collaborator Author

I have no never used actions but I would not mind to migrate since we are facing issues with Travis. I will have a look at it as soon as I have a time.

I will try to make a patch for this one soon.

@abhiabhi94
Copy link
Collaborator Author

One more thing, you'll have to add the password token to the secrets for automated release to PyPI with actions. I would suggest using a manual release as there have been instances in the past when secrets have been leaked(also I don't like microsoft).

I can handle the release process, if you don't have the time. In case, you have any other suggestions, they are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xss injection
2 participants